PMD Results

The following document contains the results of PMD 5.3.5.

Files

cn/home1/oss/environment/admin/AbstractZuulFilter.java

Violation Line
Field filterOrder has the same name as a method 10
Field filterType has the same name as a method 11
It is a good practice to call super() in a constructor 13–16

cn/home1/oss/environment/admin/AdminApplication.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 62

cn/home1/oss/environment/admin/BasicAuthFilter.java

Violation Line
A method should have only one exit point, and that should be the last statement in the method 49
Local variable 'basicAuthCode' could be declared final 69
Parameter 'requestUri' is not assigned and could be declared final 95

cn/home1/oss/environment/admin/ClientKey.java

Violation Line
Avoid unused private fields such as 'serviceId'. 25
Perhaps 'serviceId' could be replaced by a local variable. 25
Perhaps 'userName' could be replaced by a local variable. 26
Avoid unused private fields such as 'userName'. 26
Avoid unused private fields such as 'password'. 27
Perhaps 'password' could be replaced by a local variable. 27

cn/home1/oss/environment/admin/PatchedStatusUpdater.java

Violation Line
Perhaps 'applicationOps' could be replaced by a local variable. 31
Avoid unused private fields such as 'applicationOps'. 31
Avoid using redundant field initializer for 'active' 37
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 89
Comment is too large: Line too long 107
A method should have only one exit point, and that should be the last statement in the method 140
Local variable 'httpHeaders' could be declared final 156
Local variable 'authHeader' could be declared final 157

cn/home1/oss/environment/admin/ServiceMonitor.java

Violation Line
Local variable 'start' could be declared final 42
Local variable 'end' could be declared final 44

cn/home1/oss/environment/admin/WebMvcConfiguration.java

Violation Line
Parameter 'registry' is not assigned and could be declared final 16

cn/home1/oss/environment/admin/WebSecurityConfig.java

Violation Line
Local variable 'user' could be declared final 66