PMD Results

The following document contains the results of PMD 5.3.5.

Files

cn/home1/oss/environment/configlint/ConfigLintApplication.java

Violation Line
Local variable 'runner' could be declared final 11
Local variable 'status' could be declared final 12
System.exit() should not be used in J2EE/JEE apps 14

cn/home1/oss/environment/configlint/PropertyValidator.java

Violation Line
Possible God class (WMC=88, ATFD=11, TCC=0.0) 1307
Variables that are final and static should be all capitals, 'log' is not all capitals. 19
The class 'StrictPropertyLoader' has a Standard Cyclomatic Complexity of 14 (Highest = 14). 30174
The class 'StrictPropertyLoader' has a Cyclomatic Complexity of 18 (Highest = 21). 30174
The class 'StrictPropertyLoader' has a Modified Cyclomatic Complexity of 12 (Highest = 12). 30174
StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time). 31
The method 'load' has a Modified Cyclomatic Complexity of 12. 3496
The method 'load' has a Cyclomatic Complexity of 21. 3496
The method 'load' has a Standard Cyclomatic Complexity of 12. 3496
The method load() has an NPath complexity of 1090 3496
Avoid assignments in operands 44
Avoid using Literals in Conditional Statements 62
Use bitwise inversion to invert boolean values 63
Consider using varargs for methods or constructors which take an array the last parameter. 99
Avoid reassigning parameters such as 'convtBuf' 99
Avoid reassigning parameters such as 'off' 99
The method 'loadConvert' has a Modified Cyclomatic Complexity of 12. 99173
The method 'loadConvert' has a Standard Cyclomatic Complexity of 14. 99173
Avoid reassigning parameters such as 'off' 99
The method 'loadConvert' has a Cyclomatic Complexity of 14. 99173
Avoid reassigning parameters such as 'off' 99
Avoid prefixing parameters by in, out or inOut. Uses Javadoc to document this behavior. 99
Local variable 'end' could be declared final 110
Avoid using Literals in Conditional Statements 114
Avoid using Literals in Conditional Statements 116
Avoid using Literals in Conditional Statements 157
Avoid using Literals in Conditional Statements 159
Avoid using Literals in Conditional Statements 161
Avoid using Literals in Conditional Statements 163
The class 'LineReader' has a Standard Cyclomatic Complexity of 10 (Highest = 26). 176306
The class 'LineReader' has a Cyclomatic Complexity of 12 (Highest = 34). 176306
The class 'LineReader' has a Modified Cyclomatic Complexity of 10 (Highest = 26). 176306
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 188
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 189
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 190
Avoid using redundant field initializer for 'inLimit' 191
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 191
Avoid using redundant field initializer for 'inOff' 192
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 192
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 193
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 194
The method 'readLine' has a Cyclomatic Complexity of 34. 196305
The method 'readLine' has a Modified Cyclomatic Complexity of 26. 196305
The method readLine() has an NPath complexity of 2217889 196305
Avoid really long methods. 196305
The method 'readLine' has a Standard Cyclomatic Complexity of 26. 196305
A method should have only one exit point, and that should be the last statement in the method 214
A method should have only one exit point, and that should be the last statement in the method 219
Avoid using Literals in Conditional Statements 231
Local variable 'buf' could be declared final 260
Avoid using Literals in Conditional Statements 265
Use bitwise inversion to invert boolean values 266
A method should have only one exit point, and that should be the last statement in the method 288
Avoid using Literals in Conditional Statements 297

cn/home1/oss/environment/configlint/ValidateRunner.java

Violation Line
Variables that are final and static should be all capitals, 'log' is not all capitals. 15
A method should have only one exit point, and that should be the last statement in the method 57
A method should have only one exit point, and that should be the last statement in the method 63
A method should have only one exit point, and that should be the last statement in the method 67

cn/home1/oss/environment/configlint/YmlValidator.java

Violation Line
Variables that are final and static should be all capitals, 'log' is not all capitals. 15